fix(chat): don't cancel an active send when New Chat resolves into its session#706
Open
bdtsimon wants to merge 1 commit into
Open
fix(chat): don't cancel an active send when New Chat resolves into its session#706bdtsimon wants to merge 1 commit into
bdtsimon wants to merge 1 commit into
Conversation
…s session When a New Chat resolves from its temporary state into the real session key, the navigation-change effect treated that internal resolution as a genuine navigation and called cancelStreaming(), surfacing a false "Operation interrupted" even though the gateway was still producing a valid stream. Guard the cancel so an active send that is resolving into the now-active session (matched by sessionKey / friendlyId) is not cancelled. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a New Chat resolves from its temporary state into the real session key, the navigation-change effect in
ChatScreentreats that internal resolution as a genuine navigation and callscancelStreaming(). The gateway keeps producing a valid stream, but the UI surfaces a false "Operation interrupted" (it reproduced far less in incognito, which pointed at UI/session state rather than the gateway).Fix
Guard the cancel: when an active send is resolving into the now-active session (matched by
sessionKey/friendlyId), it is not cancelled. Genuine navigations still cancel exactly as before. One focused change inchat-screen.tsx.Found and fixed while running a self-hosted deployment; tool-heavy prompts now complete without the spurious interruption.
Reviewed by bdtsimon